PF4 Charts: Add ChartAxis for custom tic labels #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1309-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4633
💛 - Coveralls |
|
Note that this is just a wrapper around a Victory component -- an initial pass, similar to the other chart components. (We're currently using VictoryAxis component directly in our code.) The @patternfly/react-charts package still needs to be themed with colors, margins, etc. |
|
As far as I'm aware, there is no overlap with this in core since we don't have a chart solution in core. |
|
Rebased |
christiemolloy
previously approved these changes
Feb 18, 2019
|
@dlabrecq Can you please rebase again please. Some changes were made in Master to fix failing Build. Thanks. |
|
Rebased. Please approve, again. |
kmcfaul
previously approved these changes
Feb 20, 2019
ChartAxis is a wrapper for VictoryAxis, which allows users to customize chart tic labels along the x/y axis.
|
Rebase number 3. Please merge! |
ibolton336
approved these changes
Feb 23, 2019
redallen
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartAxis is a wrapper for VictoryAxis, which allows users to customize chart tic labels along the x/y axis.
This will allow Cost Management project to customize the tic labels as needed. For example, instead of crowding the chart with too many labels, we can limit the number and customize the label values.
Cost Management Example:
PatternFly React Example:
